Re: [PATCH] ASoC: dwc: remove 'out of memory' message

From: Takashi Sakamoto
Date: Sun Feb 26 2017 - 03:04:44 EST


Hi,

On Feb 25 2017 20:03, Mihai Burduselu wrote:
Reported by checkpatch.pl
Signed-off-by: Mihai Burduselu <michelcatalin@xxxxxxxxx>
---
sound/soc/dwc/designware_i2s.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
index 9c46e4112026..6479768cc6a1 100644
--- a/sound/soc/dwc/designware_i2s.c
+++ b/sound/soc/dwc/designware_i2s.c
@@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
const char *clk_id;

dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
- if (!dev) {
- dev_warn(&pdev->dev, "kzalloc fail\n");
+ if (!dev)

The line for 'dev_warn()' should be kept.

return -ENOMEM;
- }

dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
if (!dw_i2s_dai)


Regards

Takashi Sakamoto