Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate
From: Daniel Vetter
Date: Sun Feb 26 2017 - 15:12:25 EST
On Fri, Feb 24, 2017 at 10:31:25AM -0600, Rob Herring wrote:
> On Fri, Feb 24, 2017 at 10:14 AM, Benjamin Gaignard
> <benjamin.gaignard@xxxxxxxxxx> wrote:
> > Lots of calls to of_platform_populate() are not unbalanced by a call
> > to of_platform_depopulate(). This create issues while drivers are
> > bind/unbind.
> >
> > In way to solve those issues is to add devm_of_platform_populate()
> > which will call of_platform_depopulate() when the device is unbound
> > from the bus.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> > ---
> > version 2:
> > - simplify function prototype to only keep device as parameter
> >
> > drivers/of/platform.c | 71 +++++++++++++++++++++++++++++++++++++++++++++
> > include/linux/of_platform.h | 11 +++++++
> > 2 files changed, 82 insertions(+)
>
> For this and patch 2:
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
Is this an ack for merging both through drm-misc, or should we do a
topic-branch dance here?
/me not sure anymore what we discussed here already
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch