Re: [PATCH] asm-generic: Force cast get_user() setting x to 0

From: Arnd Bergmann
Date: Mon Feb 27 2017 - 10:53:14 EST


On Sat, Feb 25, 2017 at 2:24 AM, Stephen Boyd <stephen.boyd@xxxxxxxxxx> wrote:
> Quoting Stephen Boyd (2017-02-17 08:52:29)
>> If we call get_user() with an __le* or __be* type sparse will
>> complain when we assign the result to 0 on the faulting path.
>> Let's force cast here so that sparse doesn't complain. This
>> mirrors what we do in __get_user() as well.
>>
>> Signed-off-by: Stephen Boyd <stephen.boyd@xxxxxxxxxx>
>> ---
>>
>> I made a similar fix to arm64 headers, and it looks like asm-generic
>> would need the same fix.
>
> I suppose we can ignore this. I was using sparse v0.5.0 but it seems
> that later versions of sparse don't complain here anymore as Luc has
> pointed out.

Ok, thanks for the follow-up.

Arnd