Re: [PATCH v2] mfd: Add Cherrytrail WhiskeyCove PMIC driver

[Andy Shevchenko]

On Mon, Feb 27, 2017 at 11:38 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non
> upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal
> version which implements just enough to get ACPI PMIC opregion support to
> work, so that suspend/resume will work on machines with this PMIC.
>
> Cc: Bin Gao <bin.gao@xxxxxxxxx>
> Cc: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> Changes in v2:

You were too fast. Please, give a time for reviewers to do their job.

So, please address comments per v2 first.

> -Since this uses plain mfd and not the intel_soc_pmic stuff give it
>  its own Kconfig and allow this to be built as a module

> -Add missing #include <acpi/acpi_bus.h>

Do we need it explicitly included?

-- 
With Best Regards,
Andy Shevchenko