Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL

From: Dmitry Torokhov
Date: Tue Feb 28 2017 - 01:28:38 EST


On February 27, 2017 10:13:43 PM PST, Heiko Schocher <hs@xxxxxxx> wrote:
>Hello David,
>
>Am 28.02.2017 um 06:30 schrieb David Lechner:
>> On 02/27/2017 11:19 PM, Heiko Schocher wrote:
>>> Hello David,
>>>
>>> Am 27.02.2017 um 19:11 schrieb David Lechner:
>>>> On 02/20/2017 02:37 AM, Heiko Schocher wrote:
>>>>> From: Guan Ben <ben.guan@xxxxxxxxxxxx>
>>>>>
>>>>> extend the pwm-beeper driver to support customized frequency
>>>>> for SND_BELL from device tree.
>>>>>
>>>>> Signed-off-by: Guan Ben <ben.guan@xxxxxxxxxxxx>
>>>>> Signed-off-by: Mark Jonas <mark.jonas@xxxxxxxxxxxx>
>>>>> [hs@xxxxxxx: adapted to 4.10-rc7]
>>>>> Signed-off-by: Heiko Schocher <hs@xxxxxxx>
>>>>> ---
>>>>>
>>>>> Changes in v2:
>>>>> - add comment from Rob Herring:
>>>>> rename property name "bell-frequency" to "beeper-hz"
>>>>
>>>> Is there a separate patch for the devicetree bindings
>documentation?
>>>
>>> No, it is in this patch ... In the meantime I got an
>>> Acked-by from Rob Herring ...
>>>
>>
>> What I should have said is that, in general, I think it is preferred
>to have the device tree
>> bindings as a separate patch from the code changes.
>
>I can split this into 2 patches ...

Don't - since Rob already asked DT change you don't need to post to device tree list again and I'll merge them back together since they do not make sense separately.


Thanks.

--
Dmitry