Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters

From: Greg KH
Date: Tue Feb 28 2017 - 14:36:21 EST


On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote:
> This patch fixes warning of line over 80 characters, as issued by
> checkpatch.pl
>
> Signed-off-by: Chetan Sethi <cpsethi369@xxxxxxxxx>
> ---
> v2:
> - split multiple changes across different patches
> v3:
> - mentioned patch revision in subject
> v4:
> - modified description to exclude mention of patch number from changelog
> v5:
> - updated series for removing additional checkpatch error introduced
>
> drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> index 9ab80e1..668202d 100644
> --- a/drivers/staging/ks7010/ks_wlan.h
> +++ b/drivers/staging/ks7010/ks_wlan.h
> @@ -18,10 +18,10 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
>
> -#include <linux/spinlock.h> /* spinlock_t */
> -#include <linux/sched.h> /* wait_queue_head_t */
> -#include <linux/types.h> /* pid_t */
> -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */
> +#include <linux/spinlock.h> /* spinlock_t */
> +#include <linux/sched.h> /* wait_queue_head_t */
> +#include <linux/types.h> /* pid_t */
> +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */
> #include <linux/etherdevice.h>
> #include <linux/wireless.h>
> #include <linux/atomic.h> /* struct atomic_t */
> @@ -36,7 +36,8 @@
>
> #ifdef KS_WLAN_DEBUG
> #define DPRINTK(n, fmt, args...) \
> - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> + if (KS_WLAN_DEBUG > (n)) \

Why did you not use a tab here to indent this line as you were modifying
it?

thanks,

greg k-h