Re: [PATCH] clk: meson: fix SET_PARM macro

From: Jerome Brunet
Date: Tue Feb 28 2017 - 16:41:52 EST


On Tue, 2017-02-28 at 13:26 -0800, Stephen Boyd wrote:
> On 02/28, Jerome Brunet wrote:
> > parameter val is not enclosed in parenthesis which is buggy when
> > given an
> > expression instead of a simple value
> >
> > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>
> Fixes tag? Is there a place in the code that is using a complex
> expression for val right now?
>

Not if with what's already in, afaik. However "clk: meson: mpll: add rw
operation" I sent earlier today uses a ternary operator for val.
That'sÂÂhow I found this issue. Instead of running the test, it would
always use the "else" clause.

I realize I should sent these patches in the same series.
Would you prefer me to do so ?

Jerome