Re: [PATCH v4 15/36] platform: add video-multiplexer subdevice driver

[Steve Longerbeam]

On 02/27/2017 06:41 AM, Rob Herring wrote:
> On Wed, Feb 15, 2017 at 06:19:17PM -0800, Steve Longerbeam wrote:
> > From: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> >
> > This driver can handle SoC internal and external video bus multiplexers,
> > controlled either by register bit fields or by a GPIO. The subdevice
> > passes through frame interval and mbus configuration of the active input
> > to the output side.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> >
> > --
> >
> > - fixed a cut&paste error in vidsw_remove(): v4l2_async_register_subdev()
> >    should be unregister.
> >
> > - added media_entity_cleanup() and v4l2_device_unregister_subdev()
> >    to vidsw_remove().
> >
> > - added missing MODULE_DEVICE_TABLE().
> >    Suggested-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> >
> > - there was a line left over from a previous iteration that negated
> >    the new way of determining the pad count just before it which
> >    has been removed (num_pads = of_get_child_count(np)).
> >
> > - Philipp Zabel has developed a set of patches that allow adding
> >    to the subdev async notifier waiting list using a chaining method
> >    from the async registered callbacks (v4l2_of_subdev_registered()
> >    and the prep patches for that). For now, I've removed the use of
> >    v4l2_of_subdev_registered() for the vidmux driver's registered
> >    callback. This doesn't affect the functionality of this driver,
> >    but allows for it to be merged now, before adding the chaining
> >    support.
> >
> > Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>
> > ---
> >   .../bindings/media/video-multiplexer.txt           |  59 +++
> Please make this a separate commit.

Done.

Steve