Re: [PATCH v4 24/36] [media] add Omnivision OV5640 sensor driver

[Steve Longerbeam]

On 02/27/2017 06:45 AM, Rob Herring wrote:
> On Wed, Feb 15, 2017 at 06:19:26PM -0800, Steve Longerbeam wrote:
> > This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta
> > branch, modified heavily to bring forward to latest interfaces and code
> > cleanup.
> >
> > Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/media/i2c/ov5640.txt       |   43 +
> Please split to separate commit.

Done.

> >   drivers/media/i2c/Kconfig                          |    7 +
> >   drivers/media/i2c/Makefile                         |    1 +
> >   drivers/media/i2c/ov5640.c                         | 2109 ++++++++++++++++++++
> >   4 files changed, 2160 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.txt
> >   create mode 100644 drivers/media/i2c/ov5640.c
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.txt b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> > new file mode 100644
> > index 0000000..4607bbe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> > @@ -0,0 +1,43 @@
> > +* Omnivision OV5640 MIPI CSI-2 sensor
> > +
> > +Required Properties:
> > +- compatible: should be "ovti,ov5640"
> > +- clocks: reference to the xclk input clock.
> > +- clock-names: should be "xclk".
> > +- DOVDD-supply: Digital I/O voltage supply, 1.8 volts
> > +- AVDD-supply: Analog voltage supply, 2.8 volts
> > +- DVDD-supply: Digital core voltage supply, 1.5 volts
> > +
> > +Optional Properties:
> > +- reset-gpios: reference to the GPIO connected to the reset pin, if any.
> > +- pwdn-gpios: reference to the GPIO connected to the pwdn pin, if any.
> Use powerdown-gpios here as that is a somewhat standard name.

Done.

> Both need to state what is the active state.

Done.

Steve