Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

[Loh, Tien Hock]

Arnd, Greg,

I checked the attributes returned by the soc attribute subsystem, but
it seems that it is lacking something equivalent to timestamp in the
Intel System ID controller. Do you think it is better to add a new
attribute (named timestamp) to soc or create a new sysfs entry like
what I did?

Thanks
Tien HockÂ

On Kha, 2017-02-23 at 16:15 +0800, Loh, Tien Hock wrote:
> OK then I'll move it into driver/soc/ in that case.
> 
> On Kha, 2017-02-23 at 09:05 +0100, Arnd Bergmann wrote:
> > 
> > On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock <tien.hock.loh@inte
> > l.
> > com> wrote:
> > > 
> > > 
> > > On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote:
> > > > 
> > > > 
> > > > On Wed, Feb 15, 2017 at 6:17 PM, Greg KH <gregkh@linuxfoundatio
> > > > n.
> > > > org>
> > > > wrote:
> > > > > 
> > > > > 
> > > > > 
> > > > > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > From: "Loh, Tien Hock" <tien.hock.loh@xxxxxxxxx>
> > > > > > 
> > > > > > This patch is to add Altera System ID driver.
> > > > > > User can obtain the system ID and timestamp of the system
> > > > > > by
> > > > > > reading the sysfs entry.
> > > > > > 
> > > > > > Usage:
> > > > > > cat /sys/bus/platform/devices/[addr].sysid/sysid/id
> > > > > > cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp
> > > > > If you add new sysfs attributes, you need to also add a
> > > > > Documentation/ABI/ description as well.
> > > > Maybe we could pretend that this is for a SoC and use the
> > > > standard
> > > > soc_device
> > > > attributes as well as moving the driver into drivers/soc/?>
> > > > Sorry
> > > > for the late reply.
> > > This driver can currently be used by ARM and Nios II, so moving
> > > it
> > > into
> > > drivers/soc might not be the best idea.
> > Why not? drivers/soc/ was specifically introduced for stuff that is
> > used on
> > some SoC but across more than one architecture (otherwise it would
> > be
> > in arch/foo/). This seems to fit perfectly.
> > 
> > ÂÂÂÂÂArnd