Re: [PATCH] x86/acpi: Fix a warning message in logical CPU IDs allocation

From: Ingo Molnar
Date: Wed Mar 01 2017 - 04:20:04 EST



* Dou Liyang <douly.fnst@xxxxxxxxxxxxxx> wrote:

> Current warning message regarded the "nr_cpu_ids - 1" as the limit
> number of the CPUs. It may be confused us, for example:
> we have two CPUs, nr_cpu_ids = 2, but the warning message may
> indicate that we just have 1 CPU, which likes that:
> Only 1 processors supported.Processor 2/0x2 and the rest
> are ignored.
>
> Fix the warning message, replace "nr_cpu_ids - 1" with "nr_cpu_ids".
> And the warning message can be like that:
> APIC: NR_CPUS/possible_cpus limit of 2 reached. Processor 2/0x2
> and the rest are ignored.
>
> Signed-off-by: Dou Liyang <douly.fnst@xxxxxxxxxxxxxx>

The patch is correct, but the title is wrong (it's 'apic', not 'acpi'), plus the
changelog is unreadable. Furthermore the changelog does not declare the changing
of the return code to -EINVAL ...

I fixed all that in the commit below, but please be more careful in the future.

Thanks,

Ingo

=======================>