Re: [RESEND 2] [PATCH] rlimits: Print more information when limits are exceeded
From: Thomas Gleixner
Date: Wed Mar 01 2017 - 05:34:57 EST
On Sat, 18 Feb 2017, Arun Raghavan wrote:
> This dumps some information in logs when a process exceeds its CPU or RT
> limits (soft and hard). Makes debugging easier when userspace triggers
> these limits.
Sigh. This changelog sucks. "dumps some information" is pretty useless and
it does not explain WHY you want to do that. Please structure the changelog
in a way which makes it easy to understand.
1) Problem description
2) Solution
> diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
> index e9e8c10..6dbcf84 100644
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -860,6 +860,9 @@ static void check_thread_timers(struct task_struct *tsk,
> * At the hard limit, we just die.
> * No need to calculate anything else now.
> */
> + printk(KERN_INFO
pr_info("CPU Watchdog Timeout (hard): %s[%d]\n",
and no artificial line breaks, please.
Thanks,
tglx