Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear

[Radim KrÄmÃÅ]

2017-02-28 11:29+0000, James Hogan:
> On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote:
>> Am 27.02.2017 um 09:45 schrieb Andrew Jones:
>> > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim KrÄmÃÅ wrote:
>> >> Signed-off-by: Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>
>> >> ---
>> >>  arch/mips/kvm/emulate.c | 1 -
>> >>  1 file changed, 1 deletion(-)
>> >>
>> >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
>> >> index 552ae2b5e911..70614ca41744 100644
>> >> --- a/arch/mips/kvm/emulate.c
>> >> +++ b/arch/mips/kvm/emulate.c
>> >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
>> >>  		 * check if any I/O interrupts are pending.
>> >>  		 */
>> >>  		if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
>> >> -			__kvm_request_clear(KVM_REQ_UNHALT, vcpu);
>> >>  			vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
>> >>  		}
>> > 
>> > should remove the {} too.
>> > 
>> 
>> With that,
>> 
>> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
> 
> and with that:
> 
> Acked-by: James Hogan <james.hogan@xxxxxxxxxx>

I'll do that when applying or posting v3,

thanks for catching that.