Re: [PATCH v2 4/5] perf: kretprobes: offset from reloc_sym if kernel supports it

From: Naveen N. Rao
Date: Wed Mar 01 2017 - 14:09:55 EST


On 2017/02/25 08:55AM, Masami Hiramatsu wrote:
> On Fri, 24 Feb 2017 17:11:03 -0300
> Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> > Em Sat, Feb 25, 2017 at 02:29:17AM +0900, Masami Hiramatsu escreveu:
> > > On Fri, 24 Feb 2017 00:46:08 +0530
> > > "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote:
> > > > Thanks. I hope that's an Ack for this patchset?
> > >
> > > OK, for 1/5, 2/5, 3/5, and 5/5;
> > >
> > > Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > >
> > > And could you make v4 series including all patches? (Not only updates)
> >
> > So, to make progress I processed these:
> >
> > [acme@jouet linux]$ git log --oneline -3
> > eb55608340b7 perf probe: Generalize probe event file open routine
> > 859d718fac06 trace/kprobes: Allow return probes with offsets and absolute addresses
> > a10489121c81 kretprobes: Ensure probe location is at function entry
> > [acme@jouet linux]$
> >
> > Waiting for Naveen to react to these last minute considerations from
> > Masami and for the Ack from the PPC guys about "[PATCH v2 2/5] powerpc:
> > kretprobes: override default function entry offset".

Thanks Arnaldo!
Sorry, couldn't get to this sooner as I was off for a day...
I see that you've picked up 3 of the patches and Ananth/Michael have
acked the powerpc patch.

I will post the remaining ones tonight/tomorrow.

>
> Thanks Arnaldo!!
>
> Naveen, please update your ppc and perf patches and send it to Arnaldo.
> I'm happy to review it.

Sure thanks, I'll work on those tonight/tomorrow.


- Naveen