Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap

[Marc Zyngier]

On 02/03/17 10:01, Mian Yousaf Kaukab wrote:
> Fix following build error for s390:
> drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_attach_group':
> drivers/vfio/vfio_iommu_type1.c:1290:25: error: implicit declaration of function 'irq_domain_check_msi_remap'
> 
> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@xxxxxxxx>
> ---
>  include/linux/irqdomain.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index 188eced6813e..137817b08cdc 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -524,6 +524,10 @@ static inline struct irq_domain *irq_find_matching_fwnode(
>  {
>  	return NULL;
>  }
> +static inline bool irq_domain_check_msi_remap(void)
> +{
> +	return true;

I'm not sure about that one. If we don't support reserved regions for
MSI, why should we return "true" here? My gut feeling is that it should
be false (because we lack the infrastructure to deal with it).

It is a bit of a moot point since the only calling site will *not* call
this in that case, but I believe that we should be consistent.

Eric, what do you think?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...