Re: [PATCH net v4 0/2] net: ethernet: bgmac: bug fixes

[David Miller]

From: David Miller <davem@xxxxxxxxxxxxx>
Date: Thu, 02 Mar 2017 12:50:15 -0800 (PST)

> From: Jon Mason <jon.mason@xxxxxxxxxxxx>
> Date: Tue, 28 Feb 2017 13:41:49 -0500
> 
>> Changes in v4:
>> * Added the udelays from the previous code (per David Miller)
>> 
>> Changes in v3:
>> * Reworked the init sequence patch to only remove the device reset if
>>   the device is actually in reset.  Given that this code doesn't bear
>>   much resemblance to the original code, I'm changing the author of the
>>   patch.  This was tested on NS2 SVK.
>> 
>> Changes in v2:
>> * Reworked the first match to make it more obvious what portions of the
>>   register were being preserved (Per Rafal Mileki)
>> * Style change to reorder the function variables in patch 2 (per Sergei
>>   Shtylyov)
>> 
>> Bug fixes for bgmac driver
> 
> Series applied.

Actually, this doesn't even compile.  Reverted...

[davem@kkuri net]$ make -s -j4
drivers/net/ethernet/broadcom/bgmac.c: In function ʽbgmac_set_mac_addressʼ:
drivers/net/ethernet/broadcom/bgmac.c:1233:23: error: ʽstruct bgmacʼ has no member named ʽmac_addrʼ; did you mean ʽphyaddrʼ?
  ether_addr_copy(bgmac->mac_addr, sa->sa_data);
                       ^~
drivers/net/ethernet/broadcom/bgmac.c:1234:38: error: ʽstruct bgmacʼ has no member named ʽmac_addrʼ; did you mean ʽphyaddrʼ?
  bgmac_write_mac_address(bgmac, bgmac->mac_addr);
                                      ^~