Re: [PATCH v2] video: fbdev: imxfb: support AUS mode

From: Bartlomiej Zolnierkiewicz
Date: Fri Mar 03 2017 - 03:56:46 EST



Hi,

On Friday, March 03, 2017 12:21:30 AM Rob Herring wrote:
> On Tue, Feb 28, 2017 at 09:04:16PM +0100, Martin Kaiser wrote:
> > Some displays require setting AUS mode in the LDCD AUS Mode Control
> > Register to work with the imxfb driver. Like the value of the Panel
> > Configuration Register, the AUS Mode Control Register's value depends on
> > the display mode.
> >
> > Allow setting this register from the device tree. Make the device tree
> > node optional to keep the DT ABI stable. This register is available only
> > on imx21 and compatible chipsets. Update the device tree bindings with
> > this info.
> >
> > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> > ---
> > v2:
> > re-sending DT bindings and code changes as one patch
>
> The opposite is what is prefered.

Do you mean that you want to have code adding bindings
and its documentation in separate patches (because that
is like it was before)? This doesn't sound good for me
from kernel changes integrity POV but if this is what
you prefer I can live with that. ;)

> > .../devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 ++
> > drivers/video/fbdev/imxfb.c | 19 +++++++++++++++++++
> > include/linux/platform_data/video-imxfb.h | 1 +
> > 3 files changed, 22 insertions(+)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics