Re: [PATCH 1/2] nvmem: Add driver for the i.MX IIM

[Srinivas Kandagatla]

On 03/03/17 09:50, Srinivas Kandagatla wrote:
> On 13/02/17 15:31, Sascha Hauer wrote:
> > From: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> >
> > This adds a readonly nvmem driver for the i.MX IC Identification Module
> > (IIM). The IIM is found on the older i.MX SoCs like the i.MX25, i.MX27,
> > i.MX31, i.MX35, i.MX51 and the i.MX53.
> >
> > The IIM can control up to 8 fuse banks with 256 bit each. Not all of the
> > banks are equipped on the different SoCs. The actual number of fuses
> > differ from 512 on the i.MX27 and 1152 on the i.MX53.
> >
> > The fuses are one time writable, but writing is currently not supported
> > in the driver.
> >
> > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>
>
> > ---
> >  drivers/nvmem/Kconfig   |  11 ++++
> >  drivers/nvmem/Makefile  |   2 +
> >  drivers/nvmem/imx-iim.c | 171
> > ++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 184 insertions(+)
> >  create mode 100644 drivers/nvmem/imx-iim.c
>
> Patch looks good to me, Will pick both bindings and this patch in next
> cycle for 4.12.
Opps sent email too quick..

Can you also make sure that ids are null terminated as reported by 
kbuild https://www.spinics.net/lists/arm-kernel/msg562543.html in next 
version.

--srini

> thanks,
> srini