Re: [PATCH v2 6/9] kasan: improve slab object description
From: Andrey Ryabinin
Date: Fri Mar 03 2017 - 08:31:11 EST
On 03/02/2017 04:48 PM, Andrey Konovalov wrote:
> Changes slab object description from:
>
> Object at ffff880068388540, in cache kmalloc-128 size: 128
>
> to:
>
> The buggy address belongs to the object at ffff880068388540
> which belongs to the cache kmalloc-128 of size 128
> The buggy address is located 123 bytes inside of
> 128-byte region [ffff880068388540, ffff8800683885c0)
>
> Makes it more explanatory and adds information about relative offset
> of the accessed address to the start of the object.
>
I don't think that this is an improvement. You replaced one simple line with a huge
and hard to parse text without giving any new/useful information.
Except maybe offset, it useful sometimes, so wouldn't mind adding it to description.