Re: [PATCH v3 0/5] Fixed compilation error

From: SIMRAN SINGHAL
Date: Fri Mar 03 2017 - 11:35:11 EST


On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
>> Fixed compilation warning in lustre/lustre/llite/range_lock.c
>
> Really? What compilation warning was removed?

CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
drivers/staging/lustre/lustre/mgc/mgc_request.c: In function
âmgc_set_info_asyncâ:
drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning:
format â%sâ expects argument of type âchar *â, but argument 3 has type
âvoid *â [-Wformat=]

I was getting this warning because of changing (char *)val to val
where val is a pointer to void.
So I fixed this by reverting this change.

Simran

>
>> simran singhal (5):
>> staging: nvec: Remove unnecessary cast on void pointer
>> staging: lustre: Remove unnecessary cast on void pointer
>> staging: lustre: lustre: Remove unnecessary cast on void pointer
>> staging: rts5208: Remove unnecessary cast on void pointer
>> staging: rtl8712: Remove unnecessary cast on void pointer
>
> What compiler warns about unnecessary casts?
>
>> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
>> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
>> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
>> drivers/staging/nvec/nvec_kbd.c | 2 +-
>> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
>> drivers/staging/rts5208/rtsx_transport.c | 3 +--
>> 6 files changed, 11 insertions(+), 13 deletions(-)
>>