Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

[Alexey Brodkin]

Hi Jose,

On Fri, 2017-03-03 at 18:05 +0000, Jose Abreu wrote:
> Hi Alexey,
> 
> 
> On 03-03-2017 13:27, Alexey Brodkin wrote:
> > 
> > 
> > So if I understood you correct here what I really need is just to get rid of existing check,
> > right? I.e. the following is to be in v2 respin:
> > ------------------------------->8-------------------------------
> > diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c
> > index ad9a95916f1f..86f1555914e8 100644
> > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c
> > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c
> > @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc)
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ~ARCPGU_CTRL_ENABLE_MASK);
> > Â}
> > Â
> > -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc,
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂstruct drm_crtc_state *state)
> > -{
> > -ÂÂÂÂÂÂÂstruct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);
> > -ÂÂÂÂÂÂÂstruct drm_display_mode *mode = &state->adjusted_mode;
> > -ÂÂÂÂÂÂÂlong rate, clk_rate = mode->clock * 1000;
> > -
> > -ÂÂÂÂÂÂÂrate = clk_round_rate(arcpgu->clk, clk_rate);
> > -ÂÂÂÂÂÂÂif (rate != clk_rate)
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn -EINVAL;
> > -
> > -ÂÂÂÂÂÂÂreturn 0;
> > -}
> > -
> > Âstatic void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂstruct drm_crtc_state *state)
> > Â{
> > @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = {
> > ÂÂÂÂÂÂÂÂ.disableÂÂÂÂÂÂÂÂ= arc_pgu_crtc_disable,
> > ÂÂÂÂÂÂÂÂ.prepareÂÂÂÂÂÂÂÂ= arc_pgu_crtc_disable,
> > ÂÂÂÂÂÂÂÂ.commitÂÂÂÂÂÂÂÂÂ= arc_pgu_crtc_enable,
> > -ÂÂÂÂÂÂÂ.atomic_checkÂÂÂ= arc_pgu_crtc_atomic_check,
> > ÂÂÂÂÂÂÂÂ.atomic_beginÂÂÂ= arc_pgu_crtc_atomic_begin,
> > Â};
> > ------------------------------->8-------------------------------
> 
> I don't think you can remove the check entirely as this will make
> any mode be accepted, right?

Correct. Otherwise we'll get some modes and devices that
don't work.

Remember our saga with 74.25 vs 74.40 MHz?

With our PLLs on AXS and HSDK boards we may generate 74.25 MHz clock
which satisfy some monitors especially those who pass correct EDID to the host.
But what if EDID is either corrupted or doesn't exist (that's my case with
some industrial monitor as well as with old DVI monitor)?

In that case Linux kernel attempts to calculate all the values including pixel clock
but then instead of 74.25 we'll get 74.40 and equipment that used to work is no longer useful.

So strictly speaking existing check makes perfect sense. But it reduces
compatibility with not very good monitors.

Probably better solution to the problem is just to throw away [my] faulty HW and
buy equipment that conforms to standards (not really sure if EDID is a hard
requirement for DVI/HDMI displays or this is just an option).

BTW I'm wondering if there're any guidelines on what could be pixel clock
deviation from the requested one?

-Alexey