Re: [PATCH 4/4] thp: fix MADV_DONTNEED vs clear soft dirty race

From: Andrew Morton
Date: Fri Mar 03 2017 - 17:41:18 EST


On Thu, 2 Mar 2017 18:10:34 +0300 "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:

> Yet another instance of the same race.
>
> Fix is identical to change_huge_pmd().

Nit: someone who is reading this changelog a year from now will be
quite confused - how do they work out what the race was?

I'll add

: See "thp: fix MADV_DONTNEED vs. numa balancing race" for more details.

to the changelogs to help them a bit.

Also, it wasn't a great idea to start this series with a "Restructure
code in preparation for a fix". If people later start hitting this
race, the fixes will be difficult to backport. I'm OK with taking that
risk, but please do bear this in mind in the future.