RE: [PATCH 1/1] Drivers: hv: util: don't forget to init host_ts.lock

From: KY Srinivasan
Date: Sat Mar 04 2017 - 19:03:18 EST




> -----Original Message-----
> From: kys@xxxxxxxxxxxxxxxxxxxxxx [mailto:kys@xxxxxxxxxxxxxxxxxxxxxx]
> Sent: Monday, February 27, 2017 5:26 PM
> To: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> vkuznets@xxxxxxxxxx; jasowang@xxxxxxxxxx;
> leann.ogasawara@xxxxxxxxxxxxx
> Cc: Dexuan Cui <decui@xxxxxxxxxxxxx>; KY Srinivasan
> <kys@xxxxxxxxxxxxx>; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; Stephen
> Hemminger <sthemmin@xxxxxxxxxxxxx>
> Subject: [PATCH 1/1] Drivers: hv: util: don't forget to init host_ts.lock
>
> This&nbsp;sender&nbsp;failed&nbsp;our&nbsp;fraud&nbsp;detection&nbs
> p;checks&nbsp;and&nbsp;may&nbsp;not&nbsp;be&nbsp;who&nbsp;they&
> nbsp;appear&nbsp;to&nbsp;be.&nbsp;Learn&nbsp;about&nbsp;<a
> href="http://aka.ms/LearnAboutSpoofing";>spoofing</a>
>
> From: Dexuan Cui <decui@xxxxxxxxxxxxx>
>
> Without the patch, I always get a "BUG: spinlock bad magic" warning.
>
> Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source")
> Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> Cc: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> Cc: "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>
> Cc: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Cc: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> ---
> drivers/hv/hv_util.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> index 3042eaa..186b100 100644
> --- a/drivers/hv/hv_util.c
> +++ b/drivers/hv/hv_util.c
> @@ -590,6 +590,8 @@ static int hv_timesync_init(struct hv_util_service *srv)
> if (!hyperv_cs)
> return -ENODEV;
>
> + spin_lock_init(&host_ts.lock);
> +
> INIT_WORK(&wrk.work, hv_set_host_time);
>
> /*
> --
> 1.7.1

Greg,

Please drop this patch; I am going to resend.

K. Y