Re: [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer

[James Simmons]

> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
> 
> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>

Reviewed-by: James Simmons <jsimmons@xxxxxxxxxxxxx>

> ---
>  drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> index 271e189..09b46924 100644
> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> @@ -640,7 +640,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg,
>  	int			remote_gf_size = 0;
>  	int			rc;
>  
> -	gf = (struct getinfo_fid2path *)karg;
> +	gf = karg;
>  	tgt = lmv_find_target(lmv, &gf->gf_fid);
>  	if (IS_ERR(tgt))
>  		return PTR_ERR(tgt);
> @@ -657,7 +657,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg,
>  		struct getinfo_fid2path *ori_gf;
>  		char *ptr;
>  
> -		ori_gf = (struct getinfo_fid2path *)karg;
> +		ori_gf = karg;
>  		if (strlen(ori_gf->gf_path) +
>  		    strlen(gf->gf_path) > ori_gf->gf_pathlen) {
>  			rc = -EOVERFLOW;
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>