Re: [PATCH] ib_srp: Let compiler ignore the useless debug code

[Leon Romanovsky]

On Fri, Feb 24, 2017 at 04:16:31PM +0000, Bart Van Assche wrote:
> On Fri, 2017-02-24 at 16:44 +0800, Minfei Huang wrote:
> > "if (0)" is used to make this block of debug code not be executed. There
> > is a more elegant way to let compiler ignore this code, using
> > "#if 0 .. #endif" instead.
> >
> > Although it may be optimised by some compilers with specified parameter,
> > just for readable.
>
> #if 0 / #endif prevents the compiler from checking the syntax of the code.
> Such code tends to grow syntax errors. So I'm not sure this patch is an
> improvement.

Agree and especially without support of bloat-o-meter, all these talks
about dumb compiler are not informative.

>
> Bart.

Attachment: signature.asc
Description: PGP signature