Re: [PATCH 08/12] gpio: davinci: use devm_irq_alloc_descs()

[Keerthy]

On Saturday 04 March 2017 09:53 PM, Bartosz Golaszewski wrote:
> This driver never frees the interrupt descriptors it allocates. Fix
> it by using the resource managed version of irq_alloc_descs().

Acked-by: Keerthy <j-keerthy@xxxxxx>

> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> ---
>  drivers/gpio/gpio-davinci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 72f49d1..ac17357 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -483,7 +483,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
>  	clk_prepare_enable(clk);
>
>  	if (!pdata->gpio_unbanked) {
> -		irq = irq_alloc_descs(-1, 0, ngpio, 0);
> +		irq = devm_irq_alloc_descs(dev, -1, 0, ngpio, 0);
>  		if (irq < 0) {
>  			dev_err(dev, "Couldn't allocate IRQ numbers\n");
>  			return irq;