Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply

From: Jiri Kosina
Date: Mon Mar 06 2017 - 07:18:19 EST


On Tue, 7 Feb 2017, Benjamin Tissoires wrote:

> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcase POWER_SUPPLY_PROP_MANUFACTURER:
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂval->strval = "Logitech, Inc.";
> >
> > I don't like this change. I'd prefer the concatenated manufacturer and
> > model strings leading to user-friendly strings, and "Logitech T650" is
> > better than "Logitech, Inc. T650".
>
> Is this the only problematic issue? We are at rc7 already so I would
> like to have the final version ready ASAP.

Bastien, do you have any input on the rest of the series please?

Thanks,

--
Jiri Kosina
SUSE Labs