Re: [PATCH v10 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

[Javier Martinez Canillas]

Hello Hoegeun,

On 02/21/2017 10:09 PM, Hoegeun Kwon wrote:
> From: Hyungwon Hwang <human.hwang@xxxxxxxxxxx>
> 
> This patch add the panel device tree node for S6E3HA2 display
> controller to TM2 dts.
> 
> Signed-off-by: Hyungwon Hwang <human.hwang@xxxxxxxxxxx>
> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx>
> Tested-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> index dea0a6f..db3fed2 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> @@ -52,6 +52,18 @@
>      assigned-clock-rates = <250000000>, <400000000>;
>  };

I would add a line here.

>  +&dsi {
> +    panel@0 {
> +        compatible = "samsung,s6e3ha2";
> +        reg = <0>;
> +        vdd3-supply = <&ldo27_reg>;
> +        vci-supply = <&ldo28_reg>;
> +        reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
> +        enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
> +        te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
> +    };
> +};
> +

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America