Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT

[Jon Mason]

On Sun, Mar 5, 2017 at 8:13 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
>
>
> On 03/02/2017 04:21 PM, Jon Mason wrote:
>> From: Jon Mason <jonmason@xxxxxxxxxxxx>
>>
>> Add I2C support to the bcm5301x Device Tree.  Since no driver changes
>> are needed to enable this hardware, only the device tree changes are
>> required to make this functional.
>>
>> Signed-off-by: Jon Mason <jonmason@xxxxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
>> index 4e3fbce..2a343f2 100644
>> --- a/arch/arm/boot/dts/bcm5301x.dtsi
>> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
>> @@ -338,6 +338,15 @@
>>               };
>>       };
>>
>> +     i2c0: i2c@18009000 {
>> +             compatible = "brcm,iproc-i2c";
>> +             reg = <0x18009000 0x50>;
>> +             interrupts = <GIC_SPI 121 IRQ_TYPE_NONE>;
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             clock-frequency = <100000>;
>
> Should not this have a:
>                 status = "disabled"
>
> property by default such that boards can override this by phandle when
> there are actual I2C devices available?

Your comment appears to match the way it is being done in most device trees.

NSP implementation is identical to this.  So, if I should change it
here, I should make there too.

Thanks,
Jon

>> +     };
>> +
>>       lcpll0: lcpll0@1800c100 {
>>               #clock-cells = <1>;
>>               compatible = "brcm,nsp-lcpll0";
>>
>
> --
> Florian