Re: [PATCH] irqchip: crossbar: Fix incorrect type of register size
From: Franck Demathieu
Date: Mon Mar 06 2017 - 11:51:55 EST
On Mon, Mar 06, 2017 at 02:56:14PM +0000, Marc Zyngier wrote:
> On Mon, Mar 06 2017 at 1:41:06 pm GMT, Franck Demathieu <fdemathieu@xxxxxxxxx> wrote:
> > The 'size' variable is unsigned according to the dt-bindings.
> > As this variable is used as integer in other places, create a new variable
> > that allows to fix the following sparse issue (-Wtypesign):
> >
> > drivers/irqchip/irq-crossbar.c:279:52: warning: incorrect type in argument 3 (different signedness)
> > drivers/irqchip/irq-crossbar.c:279:52: expected unsigned int [usertype] *out_value
> > drivers/irqchip/irq-crossbar.c:279:52: got int *<noident>
> >
> > Signed-off-by: Franck Demathieu <fdemathieu@xxxxxxxxx>
>
> Are you sitting on more of these patches? If so, could you send them as
> a series instead of one a week? It would make a lot more sense to merge
> them in one go.
>
> Thanks,
>
> M.
> --
> Jazz is not dead, it just smell funny.
irq-crossbar.c is now clean from sparse point-of-view, do not expect
more patches there.
Regards,
F.