Re: [PATCH] netfilter: remove redundant check on ret being non-zero

From: Pablo Neira Ayuso
Date: Mon Mar 06 2017 - 12:06:57 EST


On Tue, Feb 28, 2017 at 11:31:15AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> ret is initialized to zero and if it is set to non-zero in the
> xt_entry_foreach loop then we exit via the out_free label. Hence
> the check for ret being non-zero is redundant and can be removed.
>
> Detected by CoverityScan, CID#1357132 ("Logically Dead Code")

Applied, thanks.