Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook

From: Masahiro Yamada
Date: Tue Mar 07 2017 - 07:13:30 EST


Hi Boris,

2017-02-20 21:28 GMT+09:00 Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>:
> The last/only user of the chip->write_page() hook (the Atmel NAND
> controller driver) has been reworked and is no longer specifying a custom
> ->write_page() implementation.
> Drop this hook before someone else start abusing it.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>


Just a minor comment.


/**
* nand_write_page - [REPLACEABLE] write one page
* @mtd: MTD device structure


Can you update the comment block for nand_write_page(), too?

[REPLACEABLE] -> [INTERNAL]




--
Best Regards
Masahiro Yamada