Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver
From: Mark Brown
Date: Tue Mar 07 2017 - 08:24:22 EST
On Mon, Mar 06, 2017 at 06:44:50PM +0100, Jerome Brunet wrote:
> + gpiod_set_value(priv->gpiod_enable, val);
You should use gpiod_set_value_cansleep() so that the driver can work
with all GPIOs unless there's a specific need to have GPIOs you can
control in interrupt (which should be the case for anything you're using
for DAPM control).
Please submit an incremental patch fixing this.
Attachment:
signature.asc
Description: PGP signature