Re: [PATCH] net: initialize msg.msg_flags in recvfrom

From: Eric Dumazet
Date: Tue Mar 07 2017 - 09:28:20 EST


On Tue, 2017-03-07 at 14:58 +0100, Alexander Potapenko wrote:
> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use
> of uninitialized memory in put_cmsg()):

I would prefer that you do not put the stack trace in the changelog,
same for the reproducer since this has little value in understanding the
impact.

It looks like a false positive, but you do not say.

recvmsg() does not care about msg.msg_flags, only KMSAN.

(The important part is that msg.msg_control and msg.msg_controllen are
0)

Fine to avoid the false positive, but better be explicit in the
changelog and says there is no visible effect for this bug.

If there is a visible effect, please state so instead of technical
details.

We try to reduce S/N in the changelogs ;)

Thanks a lot !