[PATCH 05/23] perf c2c: Fix display bug when using pipe

From: Namhyung Kim
Date: Tue Mar 07 2017 - 10:18:36 EST


Currently perf c2c report determines display mode using --stdio option,
but it could be a problem if the stdout is not a tty since setup_browser
falls back to stdio in this case. But perf c2c didn't know this and
tried to use TUI browser anyway. It should check "use_browser" variable
instead.

For example, the following command showed nothing and broke terminal
setting. Now it's fixed..

$ perf c2c report | head
=================================================
Trace Event Information
=================================================
Total records : 136
Locked Load/Store Operations : 6
Load Operations : 62
Loads - uncacheable : 0
Loads - IO : 1
Loads - Miss : 7
Loads - no mapping : 2

Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
---
tools/perf/builtin-c2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 3fac30ed92f1..5cd6d7a047b9 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -2334,7 +2334,7 @@ static int perf_c2c__hists_browse(struct hists *hists)

static void perf_c2c_display(struct perf_session *session)
{
- if (c2c.use_stdio)
+ if (use_browser == 0)
perf_c2c__hists_fprintf(stdout, session);
else
perf_c2c__hists_browse(&c2c.hists.hists);
--
2.11.0