Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into trace-event-parse.c
From: Naveen N. Rao
Date: Tue Mar 07 2017 - 11:39:27 EST
On 2017/03/07 03:03PM, Masami Hiramatsu wrote:
> On Tue, 7 Mar 2017 16:17:40 +0530
> "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote:
>
> > probe-file.c needs libelf, but scanning ftrace README does not require
> > that. As such, move the ftrace README scanning logic out of probe-file.c
> > and into trace-event-parse.c.
>
> Hmm, it seems probe-file.c doesn't require libelf at all...
> I would like to keep ftrace related things in probe-file.c.
Not sure I understand. probe-file.h explicitly calls out a need for
libelf due to the probe cache and related routines - commit
40218daea1db1 ("perf list: Show SDT and pre-cached events").
However, if you prefer to retain the ftrace README scanning here, we can
drop this patch and I can update patch 6 to check for libelf.
Thanks,
Naveen