Re: [PATCH] dmaengine: rcar-dmac: enable descriptor mode on 40bit

[Kuninori Morimoto]

Hi Laurent

Thank you for your review

> > +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
> > +			if (i == 0) {
> > +				high_src_addr = chunk->src_addr >> 32;
> > +				high_dst_addr = chunk->dst_addr >> 32;
> > +			}
> 
> This will be triggered for every iteration of the while loop, so if one sg 
> entry crosses a 32-bit boundary, you won't detect it.
> 
> I know it will mean one additional #ifdef, but I think you should move that 
> code out of the while loop as I previously proposed.

Grr indeed. Thank you for pointing it.
Hmm.. OK, I will add +1 #ifdef

Best regards
---
Kuninori Morimoto