RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

[Masaki Ota]

Hi, Dmitry,

OK, I will do it.

Best Regards,
Masaki Ota
-----Original Message-----
From: dmitry.torokhov@xxxxxxxxx [mailto:dmitry.torokhov@xxxxxxxxx] 
Sent: Wednesday, March 08, 2017 2:58 AM
To: 太田 真喜 Masaki Ota <masaki.ota@xxxxxxxxxxx>
Cc: Paul Donohue <linux-kernel@xxxxxxxxxx>; Nick Fletcher <nick.m.fletcher@xxxxxxxxx>; Joseph Salisbury <joseph.salisbury@xxxxxxxxxxxxx>; ben@xxxxxxxxxxxxxxxx; mhocko@xxxxxxxx; pali.rohar@xxxxxxxxx; rydberg@xxxxxxxxxxx; linux@xxxxxxxxxxxx; open list:HID CORE LAYER <linux-input@xxxxxxxxxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx
Subject: Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

Hi Masaki,

On Tue, Mar 07, 2017 at 08:40:20AM +0000, Masaki Ota wrote:
> Hi, Paul,
> 
> I have modified the source code. 
> 
> There are three issues.
> #1. E7=73 03 28 Button pad device is not assigned "ALPS_BUTTONPAD" Flag correctly.
> #2. E7=73 03 28 devices are not assigned " ALPS_DUALPOINT" Flag correctly.
> #3. E7=73 03 28 device cursor speed is slow.
> 
> Actually, the cause is all the same.
> E7=73 03 28 device does not get correct information from OTP.
> OTP is the device information byte. I specified correct bit.
> 
> Then, I think it is also the issue.
> #4. Stick Pointer cursor speed is fast.
> 
> I will check Stick parameter.

Could you please submit this as a proper patch now that we have confirmation that it works? Also, I wonder if V8PLUS should be full protocol instead of a flag.

Thanks.

--
Dmitry