Re: [PATCH] crypto: s5p-sss - Fix completing crypto request in IRQ handler

From: Herbert Xu
Date: Wed Mar 08 2017 - 04:44:10 EST


On Sun, Mar 05, 2017 at 07:14:07PM +0200, Krzysztof Kozlowski wrote:
> In a regular interrupt handler driver was finishing the crypt/decrypt
> request by calling complete on crypto request. This is disallowed since
> converting to skcipher in commit b286d8b1a690 ("crypto: skcipher - Add
> skcipher walk interface") and causes a warning:
> WARNING: CPU: 0 PID: 0 at crypto/skcipher.c:430 skcipher_walk_first+0x13c/0x14c
>
> The interrupt is marked shared but in fact there are no other users
> sharing it. Thus the simplest solution seems to be to just use a
> threaded interrupt handler, after converting it to oneshot.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt