Re: [PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()
From: Roger Quadros
Date: Thu Mar 09 2017 - 02:17:49 EST
Felipe,
On 15/02/17 13:38, Roger Quadros wrote:
> We need to break from all cases if we want to treat
> each one of them separately.
>
> Reported-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently")
> Cc: <stable@xxxxxxxxxxxxxxx> #v4.8+
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
Can you please pick this one for v4.11-rc? Thanks.
> ---
> drivers/usb/dwc3/dwc3-omap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index eb1b9cb..35b6351 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -250,6 +250,7 @@ static void dwc3_omap_set_mailbox(struct dwc3_omap *omap,
> val = dwc3_omap_read_utmi_ctrl(omap);
> val |= USBOTGSS_UTMI_OTG_CTRL_IDDIG;
> dwc3_omap_write_utmi_ctrl(omap, val);
> + break;
>
> case OMAP_DWC3_VBUS_OFF:
> val = dwc3_omap_read_utmi_ctrl(omap);
>
--
cheers,
-roger