Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

[David Hildenbrand]

Am 09.03.2017 um 11:43 schrieb David Hildenbrand:
> Am 08.03.2017 um 19:03 schrieb Paolo Bonzini:
>> handle_ept_violation is checking for "guest-linear-address invalid" +
>> "paging-structure walk", which is a sign of a bug in KVM.  However,
>> _all_ EPT violations without a valid guest linear address are paging
>> structure walks, because those EPT violations happen when loading the
>> guest PDPTEs.  So simplify the check to only look at bit 7 of the
>> exit qualification.
> 
> Do we have any define for this magic bit 7?
> 
> #EPT_EXITQ_GLA_VALID 0x80
> 

Introducing

#define EPT_VIOLATION_GLA_VALID_BIT
#define EPT_VIOLATION_GLA_VALID

would make sense.

-- 
Thanks,

David