Re: [PATCH 19/26] IB/ocrdma: Improve another size determination in ocrdma_alloc_mr()

[Yuval Shaia]

On Wed, Mar 08, 2017 at 02:20:42PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 8 Mar 2017 09:54:42 +0100
> 
> Replace the specification of a data type by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index 330617e1ef75..05d55d361cfe 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -3030,7 +3030,7 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd,
>  	if (!mr)
>  		return ERR_PTR(-ENOMEM);
>  
> -	mr->pages = kcalloc(max_num_sg, sizeof(u64), GFP_KERNEL);
> +	mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);

Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>

>  	if (!mr->pages) {
>  		status = -ENOMEM;
>  		goto pl_err;
> -- 
> 2.12.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html