Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static

[Tobin C. Harding]

On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote:
> On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> > > On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > > 
> > > > Greetings,
> > > > 
> > > > I bisected kdump breakage to $subject, and verified the identified
> > > > culprit via revert.  Seems kexec needs those variables as they were.
> > > 
> > > Yuck. That does not make any sense at all. I'll try to figure out why.
> > 
> > Dunno, but I did find this.
> > 
> > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
> > ./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> > ./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> > ./kexec/arch/x86_64/kexec-x86_64.c:             elf_rel_set_symbol(&info->rhdr, "backup_start",
> 
> Came so far as well. Lovely undocumented dependencies.....

I'm out of my depth on this one. If there is some task I can do to
save you time or effort, point me at it.

thanks,
Tobin.