Re: [PATCH RESEND v1] qed: Fix copy of uninitialized memory

From: David Miller
Date: Thu Mar 09 2017 - 16:18:49 EST


From: Robert Foss <robert.foss@xxxxxxxxxxxxx>
Date: Tue, 7 Mar 2017 11:46:25 -0500

> In qed_ll2_start_ooo() the ll2_info variable is uninitialized and then
> passed to qed_ll2_acquire_connection() where it is copied into a new
> memory space.
>
> This shouldn't cause any issue as long as non of the copied memory is
> every read.
> But the potential for a bug being introduced by reading this memory
> is real.
>
> Detected by CoverityScan, CID#1399632 ("Uninitialized scalar variable")
>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>

Applied.