Re: [PATCH] virtio: remove redundant check on error return err

[Stefan Hajnoczi]

On Tue, Mar 7, 2017 at 10:08 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> err has previously been checked for a -ve error return so this
> redundant check can be removed.
>
> Detected by CoverityScan, CID#1415271 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/virtio/virtio_pci_common.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
> index df548a6..ceb4395 100644
> --- a/drivers/virtio/virtio_pci_common.c
> +++ b/drivers/virtio/virtio_pci_common.c
> @@ -173,8 +173,6 @@ static int vp_find_vqs_msix(struct virtio_device *vdev, unsigned nvqs,
>                 if (err < 0)
>                         return err;
>         }
> -       if (err < 0)
> -               return err;
>
>         vp_dev->msix_vectors = nvectors;
>         vp_dev->msix_names = kmalloc_array(nvectors,

Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>