Re: [PATCH 3.16 125/370] clk: renesas: mstp: Support 8-bit registers for r7s72100

[Geert Uytterhoeven]

Hi Ben,

On Fri, Mar 10, 2017 at 12:46 PM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> 3.16.42-rc1 review patch.  If anyone has any objections, please let me know.

No objections, but you also want

commit f59de563358eb9351b7f8f0ba2d3be2ebb70b93d
Author: Chris Brandt <chris.brandt@xxxxxxxxxxx>
Date:   Tue Feb 14 11:08:05 2017 -0500

    clk: renesas: mstp: ensure register writes complete

> ------------------
>
> From: Chris Brandt <chris.brandt@xxxxxxxxxxx>
>
> commit e2a33c34ddff22ee208d80abdd12b88a98d6cb60 upstream.
>
> The RZ/A1 is different than the other Renesas SOCs because the MSTP
> registers are 8-bit instead of 32-bit and if you try writing values as
> 32-bit nothing happens...meaning this driver never worked for r7s72100.
>
> Fixes: b6face404f38 ("ARM: shmobile: r7s72100: add essential clock nodes to dtsi")
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> [bwh: Backported to 3.16: adjust filename]
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds