Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free

[Gustavo A. R. Silva]

Hello,

Quoting Felipe Balbi <balbi@xxxxxxxxxx>:

> "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx> writes:
>
> > Remove pointer dereference after free.
> >
> > Addresses-Coverity-ID: 1091173
> > Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> > ---
> > Changes in v2:
> >   Move pointer dereference before pci_pool_free()
> >   Set pointer to NULL after free
> >
> > Changes in v3:
> >   Remove 'td->next = 0x00' inside for loop.
> >   Remove unnecessary pointer nullification after free.
> >
> >   drivers/usb/gadget/udc/pch_udc.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/udc/pch_udc.c
> > b/drivers/usb/gadget/udc/pch_udc.c
> > index a97da64..8a365aa 100644
> > --- a/drivers/usb/gadget/udc/pch_udc.c
> > +++ b/drivers/usb/gadget/udc/pch_udc.c
> > @@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struct
> > pch_udc_dev *dev,
>
> line wrapped. Can't apply.

I'll fix it right away.

Thanks
--
Gustavo A. R. Silva