Re: [PATCH] tpm_crb: request and relinquish locality 0

From: Jarkko Sakkinen
Date: Sat Mar 11 2017 - 03:20:02 EST


On Fri, Mar 10, 2017 at 05:27:09PM -0700, Jason Gunthorpe wrote:
> On Sat, Mar 11, 2017 at 01:58:00AM +0200, Jarkko Sakkinen wrote:
> > Added two new callbacks to struct tpm_class_ops:
> >
> > - request_locality
> > - relinquish_locality
> >
> > These are called before sending and receiving data from the TPM.
>
> If we are going to add new ops, I think we should also adjust the
> existing drivers to use this mechanism as well?
>
> eg tis just calls its request_locality as the first thing in send..
>
> Jason

Would it be sufficient to adjust tpm_tis in addition to tpm_crb? Those
are the only once where I can edit edit-compile-run cycle.

The original commit I did worked on SKL platform that I tested but fails
on KBL but keeping the locality throughout the transmit makes it stable
on every platform I've tested.

/Jarkko