Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Remove typedef phy_ofdm_rx_status_rxsc_sgien_exintfflag

From: Julia Lawall
Date: Sat Mar 11 2017 - 12:32:20 EST




On Sat, 11 Mar 2017, simran singhal wrote:

> Remove typdef phy_ofdm_rx_status_rxsc_sgien_exintfflag and replace its uses
> in the code.
>
> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>

Acked-by: Julia Lawall <julia.lawall@xxxxxxx>

> ---
>
> v2:
> -Drop the "_" at the beginning of the name of the structure
>
> drivers/staging/rtl8192u/r8192U.h | 4 ++--
> drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h
> index a7ba8f3..524c1c9 100644
> --- a/drivers/staging/rtl8192u/r8192U.h
> +++ b/drivers/staging/rtl8192u/r8192U.h
> @@ -793,12 +793,12 @@ typedef struct _phy_cck_rx_status_report_819xusb {
> } phy_sts_cck_819xusb_t;
>
>
> -typedef struct _phy_ofdm_rx_status_rxsc_sgien_exintfflag {
> +struct phy_ofdm_rx_status_rxsc_sgien_exintfflag {
> u8 reserved:4;
> u8 rxsc:2;
> u8 sgi_en:1;
> u8 ex_intf_flag:1;
> -} phy_ofdm_rx_status_rxsc_sgien_exintfflag;
> +};
>
> typedef enum _RT_CUSTOMER_ID {
> RT_CID_DEFAULT = 0,
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 13239f4..8448e83 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -4242,7 +4242,7 @@ static void rtl8192_query_rxphystatus(struct r8192_priv *priv,
> {
> phy_sts_ofdm_819xusb_t *pofdm_buf;
> phy_sts_cck_819xusb_t *pcck_buf;
> - phy_ofdm_rx_status_rxsc_sgien_exintfflag *prxsc;
> + struct phy_ofdm_rx_status_rxsc_sgien_exintfflag *prxsc;
> u8 *prxpkt;
> u8 i, max_spatial_stream, tmp_rxsnr, tmp_rxevm, rxsc_sgien_exflg;
> s8 rx_pwr[4], rx_pwr_all = 0;
> @@ -4432,7 +4432,7 @@ static void rtl8192_query_rxphystatus(struct r8192_priv *priv,
>
> /* record rx statistics for debug */
> rxsc_sgien_exflg = pofdm_buf->rxsc_sgien_exflg;
> - prxsc = (phy_ofdm_rx_status_rxsc_sgien_exintfflag *)
> + prxsc = (struct phy_ofdm_rx_status_rxsc_sgien_exintfflag *)
> &rxsc_sgien_exflg;
> if (pdrvinfo->BW) /* 40M channel */
> priv->stats.received_bwtype[1 + prxsc->rxsc]++;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170311172100.GA18682%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>