Re: [PATCH] staging: sm750fb: Improved coding style

From: Greg Kroah-Hartman
Date: Sat Mar 11 2017 - 23:47:21 EST


On Sun, Mar 12, 2017 at 08:04:02AM +0530, Arushi Singhal wrote:
> New variables are added to make the code more readable.
> Also fixed the checkpatch issue: "Alignment should match open
> parenthesis".

When you have to say "also" in a commit message, that is a huge red-flag
that you need to break a patch up into different parts, as you are doing
multiple things. Please do so here.

thanks,

greg k-h